tms_reports

Design limitations

trip_report_data.account_type is empty in many rows

3.11 Travel account names to BigQuery Helsingin Matkapalvelukeskus (https://app.clickup.com/t/2496230/TMS-6525)

After investigating this with Sanna, Ossi and Miro, it was found that the values in trip_report_data.account_type are string, instead of integer, and this is "intentionally" so. The logic was written over five years ago, likely back then it was thought that all account types that would ever be needed, were implemented.

There are maybe 10-20 different account types in trip_report_data across all organizations, while there are over 60 account types implemented in tms_common: https://github.com/Attracs/tms-common/blob/master/doc/transport_account.md#transportaccounttype tms_booking also has the better implementation, with integer-based account types.